Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't guess the correct link #50

Merged
merged 1 commit into from
May 19, 2020
Merged

Don't guess the correct link #50

merged 1 commit into from
May 19, 2020

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented May 12, 2020

This should be merged after readthedocs/readthedocs.org#7070
is deployed.

@stsewd
Don't guess the correct link
a127366 
This should be merged after readthedocs/readthedocs.org#7070
is deployed.
@stsewd stsewd added the Status: blocked Issue is blocked on another issue label May 12, 2020
@stsewd stsewd mentioned this pull request May 12, 2020
Merged
ericholscher
ericholscher approved these changes May 13, 2020
View reviewed changes
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. I believe we're pulling master on this repo, so we shouldn't merge it until after deploy.

@stsewd stsewd merged commit faa85a9 into master May 19, 2020
@stsewd stsewd deleted the dont-use-suffix branch May 19, 2020 16:24
@YuriSizov YuriSizov mentioned this pull request May 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericholscher ericholscher ericholscher approved these changes

Assignees
No one assigned
Labels
Status: blocked Issue is blocked on another issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stsewd @ericholscher